Fix #12, Comment update to correct for microseconds not always rounding up + a… #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmknutsen
force-pushed
the
issue_12
branch
2 times, most recently
from
4c5c9a0
to
6b88ad5
Compare
|
Likely will require an update to the coverage testing, can handle with this pull request or open a new issue to address it. Also sounds more like a "warning" than "error"? |
skliper
approved these changes
Apr 7, 2020
skliper
added
the
CCB:Ready
astrogeco
changed the title
|
CCB 20200415 - APPROVED |
astrogeco
added
CCB:Approved
|
@jphickey were your requested changes addressed? |
jphickey
approved these changes
Apr 20, 2020
|
Yes, this looks fine now. |
|
Fix commit message? |
|
Sure thing...what do you want me to change it to? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Fixes #12 , Microsecond round up code doesn't round up.
Updated comments in ostimer.c to reflect what the code is actually doing.
Added debug message if microsecs per sec value does not equal 1000000.
Testing performed
Ran unit tests.
System(s) tested on
Oracle VM VirtualBox
OS: ubuntu-19.10
Versions: cFE 6.7.11.0, OSAL 5.0.9.0, PSP 1.4.7.0
Contributor Info
Dan Knutsen
NASA/Goddard